-
Couldn't load subscription status.
- Fork 78
style(FR-1577): improve dashboard statistics display design and progress visualization #4427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(FR-1577): improve dashboard statistics display design and progress visualization #4427
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 51.38% | 130/253 |
| 🔴 | Branches | 30.3% | 80/264 |
| 🔴 | Functions | 34.48% | 20/58 |
| 🔴 | Lines | 53.85% | 119/221 |
Test suite run success
55 tests passing in 3 suites.
Report generated by 🧪jest coverage report action from 1e11ddf
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.67% | 532/11384 |
| 🔴 | Branches | 3.79% | 302/7974 |
| 🔴 | Functions | 2.88% | 102/3538 |
| 🔴 | Lines | 4.62% | 514/11124 |
Test suite run success
121 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 1e11ddf
504b143 to
8fcc687
Compare
ea01880 to
de8b846
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8fcc687 to
e6beb7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the dashboard statistics display design by standardizing how progress indicators are shown across components. The main change replaces a boolean showProgress prop with a more flexible progressMode prop that supports three states: 'normal', 'ghost', and 'hidden'. The implementation migrates from custom progress steps to Ant Design's Progress component for better visual consistency.
Key Changes:
- Introduced
progressModeprop replacingshowProgressin BAIStatistic component - Replaced custom progress bar implementation with Ant Design Progress component
- Updated styling and typography properties across statistics components for improved visual consistency
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/backend.ai-ui/src/components/BAIStatistic.tsx | Core refactoring: replaced boolean showProgress with progressMode, implemented Ant Design Progress component, updated styling |
| packages/backend.ai-ui/src/components/ResourceStatistics.tsx | Updated to use new progressMode prop, added conditional styling based on display type |
| react/src/components/AgentStats.tsx | Updated prop from showProgress={true} to progressMode="normal" |
| react/src/components/MyResource.tsx | Updated prop from showProgress={true} to progressMode="normal" |
| react/src/components/MyResourceWithinResourceGroup.tsx | Updated prop from showProgress={false} to progressMode="ghost" |
| react/src/components/TotalResourceWithinResourceGroup.tsx | Updated prop from showProgress={true} to progressMode="normal" |
| react/src/components/SessionCountDashboardItem.tsx | Replaced BAIPanelItem with BAIStatistic using progressMode="hidden", updated layout styling |
| react/src/components/BAIPanelItem.tsx | Removed strong prop from Typography components |
| react/src/components/StorageStatusPanelCard.tsx | Removed unused usePrimaryColors import, updated Typography components, added color prop to BAIPanelItem |
| react/src/components/StorageStatusPanel.tsx | File completely deleted (348 lines removed) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
…ess visualization (#4427) Resolves #4426 ([FR-1577](https://lablup.atlassian.net/browse/FR-1577)) ## Summary Improve dashboard statistics display design and progress visualization by refactoring the BAIStatistic component and standardizing progress display across dashboard components. ## Changes - Refactored `BAIStatistic` component to use `progressMode` prop instead of `showProgress` - Replaced custom progress steps implementation with Ant Design Progress component - Added three progress modes: 'normal', 'ghost', and 'hidden' - Updated all dashboard components to use the new progress mode system - Improved visual consistency across resource statistics displays - Enhanced styling with better background colors and layout ## Affected Components - `packages/backend.ai-ui/src/components/BAIStatistic.tsx` - `packages/backend.ai-ui/src/components/ResourceStatistics.tsx` - `react/src/components/AgentStats.tsx` - `react/src/components/MyResource.tsx` - `react/src/components/MyResourceWithinResourceGroup.tsx` - `react/src/components/SessionCountDashboardItem.tsx` - `react/src/components/TotalResourceWithinResourceGroup.tsx` [FR-1577]: https://lablup.atlassian.net/browse/FR-1577?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
e6beb7a to
1e11ddf
Compare


Resolves #4426 (FR-1577)
Summary
Improve dashboard statistics display design and progress visualization by refactoring the BAIStatistic component and standardizing progress display across dashboard components.
Changes
BAIStatisticcomponent to useprogressModeprop instead ofshowProgressAffected Components
packages/backend.ai-ui/src/components/BAIStatistic.tsxpackages/backend.ai-ui/src/components/ResourceStatistics.tsxreact/src/components/AgentStats.tsxreact/src/components/MyResource.tsxreact/src/components/MyResourceWithinResourceGroup.tsxreact/src/components/SessionCountDashboardItem.tsxreact/src/components/TotalResourceWithinResourceGroup.tsx